Skip to content

Run cargo fmt on JOSH syncs - #2220

Open
adamgemmell wants to merge 1 commit into
rust-lang:mainfrom
adamgemmell:dev/adagem01/josh-sync-fmt
Open

Run cargo fmt on JOSH syncs#2220
adamgemmell wants to merge 1 commit into
rust-lang:mainfrom
adamgemmell:dev/adagem01/josh-sync-fmt

Conversation

@adamgemmell

Copy link
Copy Markdown
Contributor

This is what rust-analyzer does on their syncs and was recommended by Jakub on our Zulip.

In rust-lang/rust, stdarch is excluded from tidy because the version of rustfmt used can differ from the one we use in this repository (latest nightly). This change reduces the chance of a formatting error blocking rustc-pull.

It doesn't completely eliminate it as there's a chance that the formatting error is in generated code, in which case formatting it will break the checks that run the generator. In those cases we'd still need to make manual fixes to the sync branch.

@rustbot

rustbot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn
  • @Amanieu, @adamgemmell, @davidtwco, @folkertdev, @sayantn expanded to Amanieu, adamgemmell, davidtwco, folkertdev, sayantn
  • Random selection from Amanieu, davidtwco, folkertdev, sayantn

@adamgemmell
adamgemmell force-pushed the dev/adagem01/josh-sync-fmt branch from bb252d5 to 106c42a Compare September 9, 2026 11:04
@rustbot

rustbot commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants