Run cargo fmt on JOSH syncs - #2220
Open
adamgemmell wants to merge 1 commit into
Open
Conversation
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
adamgemmell
force-pushed
the
dev/adagem01/josh-sync-fmt
branch
from
September 9, 2026 11:04
bb252d5 to
106c42a
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what rust-analyzer does on their syncs and was recommended by Jakub on our Zulip.
In rust-lang/rust, stdarch is excluded from tidy because the version of rustfmt used can differ from the one we use in this repository (latest nightly). This change reduces the chance of a formatting error blocking rustc-pull.
It doesn't completely eliminate it as there's a chance that the formatting error is in generated code, in which case formatting it will break the checks that run the generator. In those cases we'd still need to make manual fixes to the sync branch.