Fix home_dir() and current_dir() regression#3938
Merged
Conversation
rami3l
approved these changes
Jul 11, 2024
Contributor
Author
Good call! Also tacked on two more commits with some quick renaming. |
2 tasks
rami3l
force-pushed
the
fix-dir-regression
branch
from
5f20b19 to
452d9f9
Compare
Co-authored-by: rami3l <rami3l@outlook.com>
rami3l
force-pushed
the
fix-dir-regression
branch
from
452d9f9 to
52157df
Compare
Contributor
Author
|
Thanks for cleaning this up for me, wasn't able to follow up yesterday! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3764 (specifically 204c8a9), I moved a bunch of code around and in the process mixed up the
OSandTestcases. Fix my mistake.Thanks @ChrisDenton for paying attention and bisecting!
As discussed in #3936.