Make auto-self-update setting work when no-self-update feature is enabled#3051
Make auto-self-update setting work when no-self-update feature is enabled#3051autumnontape wants to merge 4 commits intorust-lang:mainfrom
Conversation
|
I'd quite like to remove the no self update feature entirely. That said, can you explain the user interaction model you are aiming for here? |
|
@rbtcollins Remove it in favor of what? Do you not want distros to package rustup? The idea behind these patches is this:
|
|
If you're wondering more about how I expect the messages to be helpful to users, this is what I'm envisioning:
I do think a docs change to mention that rustup won't update itself when installed through a package manager would also be nice, if people were confused enough by the docs for a message to be added to the program itself. |
|
I think I'd like to review this when I have more brain-space. I am aware that this can be annoying (I actually use rustup via nixos on some of my systems so I'm used to seeing the message, but that doesn't mean it's entirely pleasant to keep encountering). |
Fixes #3040.
This patch series makes rustup work in the way that makes the most sense to me personally when built with self updates disabled. I've split four distinct, individually conservative changes I'd make into four patches. If you'd like me to drop or modify some of them, that's fine, of course. The first patch ("don't log on update if no-self-update is enabled but auto-self-update=disable") is the one that matters to me.
If you'd like docs or tests changes, I can do that, too, but no-self-update already doesn't seem to be covered by either. Enabling the feature causes the tests to fail even without these patches.