Skip to content

powerpc64le_unknown_freebsd.rs: link with -lgcc#158646

Open
pkubaj wants to merge 1 commit into
rust-lang:mainfrom
pkubaj:patch-1
Open

powerpc64le_unknown_freebsd.rs: link with -lgcc#158646
pkubaj wants to merge 1 commit into
rust-lang:mainfrom
pkubaj:patch-1

Conversation

@pkubaj

@pkubaj pkubaj commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double. 128 bit arithmetics are implemented in LLVM's compiler_rt, which is FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0 succeeds - noop for earlier releases.

@rustbot

rustbot commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 1, 2026
@rustbot

rustbot commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

r? @camelid

rustbot has assigned @camelid.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 16 candidates

@rust-log-analyzer

This comment has been minimized.

Comment thread compiler/rustc_target/src/spec/targets/powerpc64le_unknown_freebsd.rs Outdated
@camelid camelid assigned bjorn3 and unassigned camelid Jul 1, 2026
Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double.
128 bit arithmetics are implemented in LLVM's compiler_rt, which is
FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0
succeeds - noop for earlier releases.
@bjorn3

bjorn3 commented Jul 2, 2026

Copy link
Copy Markdown
Member

LGTM, but let's cc @asomers @MikaelUrankar as target maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants