Move cross crate tests into the appropriate folder by danieljofficial · Pull Request #157447 · rust-lang/rust

danieljofficial · 2026-06-04T20:17:28Z

Hi, I've returned with a few more reorganized tests.
r? @jieyouxu
This is part of 133895

try-job: armhf-gnu

rustbot · 2026-06-04T20:17:31Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

Kivooeo · 2026-06-05T01:00:01Z

cc @zedddie to avoid gsoc work conflicts

danieljofficial · 2026-06-05T08:26:12Z

cc @zedddie to avoid gsoc work conflicts

Noted.

jieyouxu

Thanks
@bors r+ rollup

View changes since this review

rust-bors · 2026-06-05T10:25:24Z

📌 Commit 2b55fda has been approved by jieyouxu

It is now in the queue for this repository.

@jieyouxu

…rate, r=jieyouxu Move cross crate tests into the appropriate folder Hi, I've returned with a few more reorganized tests. r? @jieyouxu This is part of [133895](rust-lang#133895)

…uwer Rollup of 8 pull requests Successful merges: - #157467 (stdarch subtree update) - #156798 (delegation: do not always generate first argument) - #157450 (mark `Encode`, `Decode`, `Mark` impls as `#[inline]`) - #157190 (Silence recursive RUSTC_LOG_FORMAT_JSON messages) - #157447 (Move cross crate tests into the appropriate folder) - #157470 (Avoid ICE when emitting TargetMachine config errors) - #157474 (Forbid optimize(none) with inline(always) or inline.) - #157475 (Add a smoke test for the optimize attribute.)

JonathanBrouwer · 2026-06-05T13:24:53Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #157481 (comment)

rust-bors · 2026-06-05T13:25:01Z

This pull request was unapproved.

This PR was contained in a rollup (#157481), which was unapproved.

View changes since this unapproval

danieljofficial · 2026-06-05T14:30:07Z

💔 I suspect this PR failed tests as part of a rollup @bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #157481 (comment)

I can't tell what might've caused this, locally the tests are passing. So I'm a bit confused about what I should change to fix this.

Move cross crate tests into the appropriate folder try-job: armhf-gnu

jieyouxu · 2026-06-05T14:34:24Z

---- [ui] tests/ui/cross-crate/stable-symbol-hash-for-trait-object-projections.rs stdout ----

error: test did not exit with success! code=Some(127) so test would pass with `run-fail`
status: exit status: 127
command: RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-client" "run" "1" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cross-crate/stable-symbol-hash-for-trait-object-projections/a" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cross-crate/stable-symbol-hash-for-trait-object-projections/auxiliary/libstable_symbol_hash_for_trait_object_projections.so"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/cross-crate/stable-symbol-hash-for-trait-object-projections/a", waiting for result
------------------------------------------
--- stderr -------------------------------
/tmp/work/test1271/a: error while loading shared libraries: libstable_symbol_hash_for_trait_object_projections.so: cannot open shared object file: No such file or directory
------------------------------------------

---- [ui] tests/ui/cross-crate/stable-symbol-hash-for-trait-object-projections.rs stdout end ----

@jieyouxu

…rate, r=jieyouxu Move cross crate tests into the appropriate folder Hi, I've returned with a few more reorganized tests. r? @jieyouxu This is part of [133895](rust-lang#133895) try-job: armhf-gnu

@jieyouxu

…rate, r=jieyouxu Move cross crate tests into the appropriate folder Hi, I've returned with a few more reorganized tests. r? @jieyouxu This is part of [133895](rust-lang#133895) try-job: armhf-gnu

rust-bors · 2026-06-07T12:44:05Z

💔 Test for 1456727 failed: CI

…uwer Rollup of 10 pull requests Successful merges: - #157447 (Move cross crate tests into the appropriate folder) - #145108 (Resolver: Batched Import Resolution) - #156119 (Further optimize `SliceIndex<str>` impl for `Range<usize>`) - #157289 (Add infallible primitive type lookups to template arg resolver) - #157540 (Cleanup and optimize `render_impls`) - #157543 (Reorganize `tests/ui/issues` [5/N]) - #156188 (riscv: promote d, e, and f target_features to CfgStableToggleUnstable) - #157323 (Document Repeat::last panic behavior) - #157545 (Suggest using comma to separate valid attribute list items) - #157559 (chore: Update annotate-snippets to 0.12.16)

@jieyouxu

…rate, r=jieyouxu Move cross crate tests into the appropriate folder Hi, I've returned with a few more reorganized tests. r? @jieyouxu This is part of [133895](rust-lang#133895) try-job: armhf-gnu

@jieyouxu

…rate, r=jieyouxu Move cross crate tests into the appropriate folder Hi, I've returned with a few more reorganized tests. r? @jieyouxu This is part of [133895](rust-lang#133895) try-job: armhf-gnu

rust-bors · 2026-06-07T21:44:32Z

⌛ Testing commit 1e1560b with merge 12abfe6...

Workflow: https://github.com/rust-lang/rust/actions/runs/27105709820

@jieyouxu

…youxu Move cross crate tests into the appropriate folder Hi, I've returned with a few more reorganized tests. r? @jieyouxu This is part of [133895](#133895) try-job: armhf-gnu

jhpratt · 2026-06-07T21:48:29Z

yielding to encompassing rollup

@bors yield

rust-bors · 2026-06-07T21:48:32Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/27105709820

The next pull request likely to be tested is #157586.

Rollup of 25 pull requests Successful merges: - #157447 (Move cross crate tests into the appropriate folder) - #145108 (Resolver: Batched Import Resolution) - #156119 (Further optimize `SliceIndex<str>` impl for `Range<usize>`) - #157224 (Manually unroll loop in `str::floor_char_boundary`) - #157289 (Add infallible primitive type lookups to template arg resolver) - #157540 (Cleanup and optimize `render_impls`) - #157444 (Couple of work product cleanups) - #157543 (Reorganize `tests/ui/issues` [5/N]) - #153513 (Syntactically reject equality predicates) - #155797 (LineWriter: cap write_vectored newline scan to avoid quadratic write_all_vectored) - #156155 (macros: report unbound metavariables directly) - #156188 (riscv: promote d, e, and f target_features to CfgStableToggleUnstable) - #156666 (Clarify meaning of ranges in pointer offset docs) - #157078 (Document equivalence of `highest_one` and `ilog2` methods on integers) - #157129 (ci: update download-artifact action to v8) - #157169 (triagebot: Update messages to direct changes to appropriate repositories) - #157323 (Document Repeat::last panic behavior) - #157370 (Clarify MaybeUninit::zeroed padding docs) - #157399 (Silence llbc's output by default to prevent rustc's linker output warning) - #157500 (Improve documentation of `align_of` and `Alignment`.) - #157545 (Suggest using comma to separate valid attribute list items) - #157559 (chore: Update annotate-snippets to 0.12.16) - #157560 (In `copy_nonoverlapping`, use `mul nuw nsw` to compute the byte size) - #157580 (Importing suggestion reported twice when reporting privacy error) - #157581 (Test fixup)

rust-bors · 2026-06-07T21:54:47Z

⌛ Testing commit 1e1560b with merge 2218429...

Workflow: https://github.com/rust-lang/rust/actions/runs/27105944494

@jieyouxu

…youxu Move cross crate tests into the appropriate folder Hi, I've returned with a few more reorganized tests. r? @jieyouxu This is part of [133895](#133895) try-job: armhf-gnu

jhpratt · 2026-06-07T21:56:51Z

@bors yield

rust-bors · 2026-06-07T21:56:54Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/27105944494

The next pull request likely to be tested is #157586.

Rollup of 25 pull requests Successful merges: - #157447 (Move cross crate tests into the appropriate folder) - #145108 (Resolver: Batched Import Resolution) - #156119 (Further optimize `SliceIndex<str>` impl for `Range<usize>`) - #157224 (Manually unroll loop in `str::floor_char_boundary`) - #157289 (Add infallible primitive type lookups to template arg resolver) - #157540 (Cleanup and optimize `render_impls`) - #157444 (Couple of work product cleanups) - #157543 (Reorganize `tests/ui/issues` [5/N]) - #153513 (Syntactically reject equality predicates) - #155797 (LineWriter: cap write_vectored newline scan to avoid quadratic write_all_vectored) - #156155 (macros: report unbound metavariables directly) - #156188 (riscv: promote d, e, and f target_features to CfgStableToggleUnstable) - #156666 (Clarify meaning of ranges in pointer offset docs) - #157078 (Document equivalence of `highest_one` and `ilog2` methods on integers) - #157129 (ci: update download-artifact action to v8) - #157169 (triagebot: Update messages to direct changes to appropriate repositories) - #157323 (Document Repeat::last panic behavior) - #157370 (Clarify MaybeUninit::zeroed padding docs) - #157399 (Silence llbc's output by default to prevent rustc's linker output warning) - #157500 (Improve documentation of `align_of` and `Alignment`.) - #157545 (Suggest using comma to separate valid attribute list items) - #157559 (chore: Update annotate-snippets to 0.12.16) - #157560 (In `copy_nonoverlapping`, use `mul nuw nsw` to compute the byte size) - #157580 (Importing suggestion reported twice when reporting privacy error) - #157581 (Test fixup)

@jieyouxu

Rollup merge of #157447 - danieljofficial:move-tests-cross-crate, r=jieyouxu Move cross crate tests into the appropriate folder Hi, I've returned with a few more reorganized tests. r? @jieyouxu This is part of [133895](#133895) try-job: armhf-gnu

Rollup of 25 pull requests Successful merges: - rust-lang/rust#157447 (Move cross crate tests into the appropriate folder) - rust-lang/rust#145108 (Resolver: Batched Import Resolution) - rust-lang/rust#156119 (Further optimize `SliceIndex<str>` impl for `Range<usize>`) - rust-lang/rust#157224 (Manually unroll loop in `str::floor_char_boundary`) - rust-lang/rust#157289 (Add infallible primitive type lookups to template arg resolver) - rust-lang/rust#157540 (Cleanup and optimize `render_impls`) - rust-lang/rust#157444 (Couple of work product cleanups) - rust-lang/rust#157543 (Reorganize `tests/ui/issues` [5/N]) - rust-lang/rust#153513 (Syntactically reject equality predicates) - rust-lang/rust#155797 (LineWriter: cap write_vectored newline scan to avoid quadratic write_all_vectored) - rust-lang/rust#156155 (macros: report unbound metavariables directly) - rust-lang/rust#156188 (riscv: promote d, e, and f target_features to CfgStableToggleUnstable) - rust-lang/rust#156666 (Clarify meaning of ranges in pointer offset docs) - rust-lang/rust#157078 (Document equivalence of `highest_one` and `ilog2` methods on integers) - rust-lang/rust#157129 (ci: update download-artifact action to v8) - rust-lang/rust#157169 (triagebot: Update messages to direct changes to appropriate repositories) - rust-lang/rust#157323 (Document Repeat::last panic behavior) - rust-lang/rust#157370 (Clarify MaybeUninit::zeroed padding docs) - rust-lang/rust#157399 (Silence llbc's output by default to prevent rustc's linker output warning) - rust-lang/rust#157500 (Improve documentation of `align_of` and `Alignment`.) - rust-lang/rust#157545 (Suggest using comma to separate valid attribute list items) - rust-lang/rust#157559 (chore: Update annotate-snippets to 0.12.16) - rust-lang/rust#157560 (In `copy_nonoverlapping`, use `mul nuw nsw` to compute the byte size) - rust-lang/rust#157580 (Importing suggestion reported twice when reporting privacy error) - rust-lang/rust#157581 (Test fixup)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 4, 2026

rustbot assigned jieyouxu Jun 4, 2026

jieyouxu approved these changes Jun 5, 2026

View reviewed changes

Comment thread tests/ui/issues/issue-2170-exe.rs

Comment thread tests/ui/cross-crate/mut-ref-write-visible-after-unwind.rs Outdated

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2026

This was referenced Jun 5, 2026

tests/ui/issues/issue-2170-exe.rs is ineffective #157477

Closed

tests/ui/issues/issue-29485.rs has a useless #[feature(recover)] #157478

Closed

JonathanBrouwer mentioned this pull request Jun 5, 2026

Rollup of 8 pull requests #157481

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 5, 2026

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 5, 2026

Auto merge of #157447 - danieljofficial:move-tests-cross-crate, r=<try>

4c58f6e

Move cross crate tests into the appropriate folder try-job: armhf-gnu

danieljofficial force-pushed the move-tests-cross-crate branch from 2b55fda to dc17feb Compare June 5, 2026 15:11

This comment was marked as outdated.

Sign in to view

jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2026

This comment was marked as outdated.

Sign in to view

JonathanBrouwer mentioned this pull request Jun 7, 2026

Rollup of 6 pull requests #157564

Closed

JonathanBrouwer mentioned this pull request Jun 7, 2026

Rollup of 11 pull requests #157569

Closed

JonathanBrouwer mentioned this pull request Jun 7, 2026

Rollup of 10 pull requests #157570

Closed

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 7, 2026

JonathanBrouwer mentioned this pull request Jun 7, 2026

Rollup of 21 pull requests #157582

Closed

jhpratt mentioned this pull request Jun 7, 2026

Rollup of 21 pull requests #157583

Closed

jhpratt mentioned this pull request Jun 7, 2026

Rollup of 25 pull requests #157586

Merged

rust-bors Bot merged commit f465e61 into rust-lang:main Jun 8, 2026
12 of 14 checks passed

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 8, 2026

rustbot added this to the 1.98.0 milestone Jun 8, 2026

Uh oh!

Conversation

danieljofficial commented Jun 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 4, 2026

Uh oh!

Kivooeo commented Jun 5, 2026

Uh oh!

danieljofficial commented Jun 5, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rust-bors Bot commented Jun 5, 2026

Uh oh!

JonathanBrouwer commented Jun 5, 2026

Uh oh!

rust-bors Bot commented Jun 5, 2026

Uh oh!

danieljofficial commented Jun 5, 2026

Uh oh!

This comment was marked as outdated.

This comment has been minimized.

jieyouxu commented Jun 5, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

rust-bors Bot commented Jun 7, 2026

Uh oh!

rust-bors Bot commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Jun 7, 2026

Uh oh!

rust-bors Bot commented Jun 7, 2026

Uh oh!

rust-bors Bot commented Jun 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Jun 7, 2026

Uh oh!

rust-bors Bot commented Jun 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

danieljofficial commented Jun 4, 2026 •

edited by rustbot

Loading

jieyouxu left a comment •

edited by rustbot

Loading

rust-bors Bot commented Jun 7, 2026 •

edited

Loading

rust-bors Bot commented Jun 7, 2026 •

edited

Loading