Skip to content

Suggest adding quotation marks to identifiers in attributes - #156797

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
ariagivens:suggest-quotes
May 28, 2026
Merged

Suggest adding quotation marks to identifiers in attributes#156797
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
ariagivens:suggest-quotes

Conversation

@ariagivens

@ariagivens ariagivens commented May 21, 2026

Copy link
Copy Markdown
Contributor

When the user provides an identifier when a literal was expected in an attribute value, suggest adding quotation marks to the identifier to make it a string literal.

For instance:

error: attribute value must be a literal
  --> $DIR/crate-type-non-crate.rs:9:16
   |
LL | #[crate_type = lib]
   |                ^^^ help: try adding quotation marks: `"lib"`

@rustbot

rustbot commented May 21, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 21, 2026
@rustbot

rustbot commented May 21, 2026

Copy link
Copy Markdown
Collaborator

r? @Kivooeo

rustbot has assigned @Kivooeo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

JonathanBrouwer
JonathanBrouwer approved these changes May 21, 2026
View reviewed changes

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work ❤️
@bors r+ rollup

View changes since this review

@JonathanBrouwer

JonathanBrouwer commented May 21, 2026

Copy link
Copy Markdown
Contributor

Bors u there???
@bors r+ rollup

@rust-bors

rust-bors Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8fec623 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 21, 2026
Closed
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 21, 2026
Closed
@JonathanBrouwer

JonathanBrouwer commented May 22, 2026

Copy link
Copy Markdown
Contributor

@bors r-
#156808 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 22, 2026
@rust-bors

rust-bors Bot commented May 22, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#156808), which was unapproved.

View changes since this unapproval

@ariagivens

ariagivens commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

I believe this will fix the test issue, but I haven't figured out how to run the apple tests to be sure.

@JonathanBrouwer

JonathanBrouwer commented May 27, 2026

Copy link
Copy Markdown
Contributor

@bors try jobs=aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 77f4876 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ariagivens

ariagivens commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

Okay I have learned the dark secrets of macos emulation. We should be good to go 🙏

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2026
@JonathanBrouwer

JonathanBrouwer commented May 27, 2026

Copy link
Copy Markdown
Contributor

@bors try jobs=aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
@JonathanBrouwer

JonathanBrouwer commented May 27, 2026

Copy link
Copy Markdown
Contributor

(Also how did you emulate macos? I haven't tried that myself yet, usually just rely on CI)

@rust-bors

rust-bors Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 8bc6e9f (8bc6e9ffbbf0617ae2aa63ffce6ae93f1eb906cb, parent: 77a4fb62f70c6ea05e1820216d903938e331d42b)

@ariagivens

ariagivens commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

(Also how did you emulate macos? I haven't tried that myself yet, usually just rely on CI)

I used QEMU and followed the instructions in this repo: https://github.com/kholia/OSX-KVM

JonathanBrouwer
JonathanBrouwer approved these changes May 28, 2026
View reviewed changes

@JonathanBrouwer JonathanBrouwer left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup
Thanks! ❤️

View changes since this review

@rust-bors

rust-bors Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1fa9548 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2026
@matthiaskrgr matthiaskrgr mentioned this pull request May 28, 2026
Merged
@rust-bors
rust-bors Bot merged commit c67006e into rust-lang:main May 28, 2026
@rustbot rustbot added this to the 1.98.0 milestone May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ariagivens @rustbot @JonathanBrouwer @rust-log-analyzer @Kivooeo