Disambiguate identical type names in impl headers#156279
Conversation
This comment has been minimized.
This comment has been minimized.
42c172b to
0fc7dd5
Compare
This comment has been minimized.
This comment has been minimized.
0fc7dd5 to
0cb49b0
Compare
|
rustbot has assigned @GuillaumeGomez. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Disambiguate identical type names in impl headers
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (bec2324): comparison URL. Overall result: ❌ regressions - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 497.725s -> 508.058s (2.08%) |
|
Small perf impact, nice. Although, we are currently discussing to do something similar (disambiguate item's name) but everywhere. Not too sure if we should merge this as is or if we should do the whole work at once... An opinion @rust-lang/rustdoc-frontend ? |
|
☔ The latest upstream changes (presumably #157586) made this pull request unmergeable. Please resolve the merge conflicts. |
Render impl header paths with enough qualification when the same visible path segment refers to different
DefIds in that header.Fixes #154960.