Skip to content

diagnostics: suggest deriving Default for enums#151412

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
WhyNovaa:diagnostics-impl-enum-fix
Jan 23, 2026
Merged

diagnostics: suggest deriving Default for enums#151412
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
WhyNovaa:diagnostics-impl-enum-fix

Conversation

@WhyNovaa
Copy link
Copy Markdown
Contributor

Fixing outdated code: now we can derive Default for enums

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 20, 2026
Copy link
Copy Markdown
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, please also add a test showcasing this change

@rust-log-analyzer

This comment has been minimized.

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Jan 20, 2026

(could you squash commits please)

@WhyNovaa WhyNovaa force-pushed the diagnostics-impl-enum-fix branch from 2cc52d2 to 846a803 Compare January 20, 2026 21:46
Comment thread tests/ui/suggestions/suggest-derive-default-for-enums.rs
@WhyNovaa WhyNovaa force-pushed the diagnostics-impl-enum-fix branch from ef6fc34 to 2f75c54 Compare January 21, 2026 16:00
@lcnr
Copy link
Copy Markdown
Contributor

lcnr commented Jan 22, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Jan 22, 2026

📌 Commit 2f75c54 has been approved by lcnr

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2026
rust-bors Bot pushed a commit that referenced this pull request Jan 22, 2026
…uwer

Rollup of 3 pull requests

Successful merges:

 - #151412 (diagnostics: suggest deriving Default for enums)
 - #151495 (Fix ICE when using zero-length SIMD type in extern static)
 - #151497 (Fix typo: 'recieve' -> 'receive' in lldb-visualizers.md)

r? @ghost
@rust-bors rust-bors Bot merged commit a2c53d6 into rust-lang:main Jan 23, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 23, 2026
rust-timer added a commit that referenced this pull request Jan 23, 2026
Rollup merge of #151412 - WhyNovaa:diagnostics-impl-enum-fix, r=lcnr

diagnostics: suggest deriving Default for enums

Fixing outdated code: now we can derive Default for enums

r? @lcnr
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 26, 2026
…uwer

Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#151412 (diagnostics: suggest deriving Default for enums)
 - rust-lang/rust#151495 (Fix ICE when using zero-length SIMD type in extern static)
 - rust-lang/rust#151497 (Fix typo: 'recieve' -> 'receive' in lldb-visualizers.md)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants