Manually update nightly version#882
Open
apoelstra wants to merge 2 commits intorust-bitcoin:masterfrom
Open
Conversation
Member
Author
|
...no, apparently we need hashes 0.14.1. |
Member
Author
|
CI failure is rust-lang/rust#138907 again and I will need to release a 15th crate to deal with it.. |
We have released upstream versions of these crates which get rid of doc_auto_cfg. Now we can update our nightly compiler.
Update from March to November...eight months of rustc having broken us.
apoelstra
force-pushed
the
2025-12/update-nightly
branch
from
f0aa99a to
1841bcd
Compare
Member
Author
|
Rebased with rust-bitcoin/rust-bitcoin#5359 |
Member
Author
|
Now it seems we need bitcoin-internals. I thought we already did this?? |
Member
Author
|
we will also need to do secp256k-sys 0.10.1. Also this might all be moot because we will need a new patch version of getrandom 0.2. Maybe we can PR upstream. |
Member
|
I was literally wondering yesterday why we had not run into the rand problem yet, I remember you mentioning it in the past. |
Member
Author
|
Will need to fix rust-bitcoin/rust-bitcoin-maintainer-tools#31 then update maintainer-tools here. |
Member
|
I did #883 to help with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will unblock #805