Merged
Conversation
|
Feedback:
A new scan will be automatically performed on the next push to the PR branch. Internal use only: Reviewer details Maintainer details |
iProdigy
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update quest-voiceover plugin to version 1.12.1.
Release: https://github.com/KevinEdry/runelite-quest-voiceover/releases/tag/v1.12.1
Bug Fixes
Several users reported that the plugin's database stops working after an internet disconnect and never recovers, even though the SQLite database is a local file that should work fine offline.
After inspecting the logs, the root cause was a chain of connection lifecycle bugs:
Closed connection never gets re-created: When the connection was closed (e.g. during a network hiccup),
closeConnection()closed it but didn't null the reference. On the next query,getConnection()saw a non-null (but closed) connection and returned it — so every subsequent query failed permanently.No connection health check:
getConnection()only checkedconnection != null, never whether it was actually still open. A stale connection was returned as-is with no way to recover.Database file corruption on interrupted downloads: The download wrote directly to the live database file with
REPLACE_EXISTING. If a download was interrupted mid-stream (as happens when internet drops), the file was left truncated/corrupt — breaking all queries until the next successful download.Changes
isClosed()health check ingetConnection()so stale connections are automatically detected and replaced.verification-metadata.xmlfor RuneLite 1.12.17.Hopefully thats enough context to give a good idea of the changes 🙏