Fix logged out state for navbar #669
Open
+78
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maebeale
force-pushed
the
fix-logged-out-state
branch
from
5f1a2e1 to
9690b1b
Compare
jmilljr24
reviewed
Jan 16, 2026
Comment on lines
+83
to
84
| <% if current_user&.super_user %> | ||
| <%= link_to facilitators_path, |
Collaborator
There was a problem hiding this comment.
@maebeale I already caught this one!! These partials should never render if there is no current_user but we weren't checking for that in _navbar.html.erb.
I already added the fix there. Doesn't hurt to have this check here as well but not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
How did you approach the change?
Anything else to add?