Add ext/strscan/depend - #218
Merged
Merged
Conversation
`tool/sync_default_gems.rb` removes the mapped directory before copying this repository over it, so ruby/ruby loses its own `ext/strscan/depend` on every sync. Keeping the file here makes the sync carry it back. Generated with `extconf.rb --update-depend`, which resolves dependencies against this repository rather than an installed Ruby, so no `$(hdrdir)` paths leak in and older Rubies still build. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed change is limited to the expected generated dependency file with no unresolved issues.
Pull request overview
Adds the autogenerated dependency file needed to preserve strscan synchronization with ruby/ruby.
Changes:
- Adds generated dependency metadata for
strscan.o.
File summaries
| File | Description |
|---|---|
ext/strscan/depend |
Declares the generated dependency for strscan.o. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strscanhas noext/strscan/depend, but ruby/ruby carries one. Misc #22206 settled on each default gem keeping its own dependency file, withminimize_dependenciesreducing it on the ruby/ruby side. Becausetool/sync_default_gems.rbclears the mapped directory before copying this repository over it, every sync dropsext/strscan/dependfrom ruby/ruby and it has to be restored by hand.This adds the file exactly as
ruby extconf.rb --update-dependgenerates it. That path scans only this repository, so it names no installed Ruby headers and no$(hdrdir)entries leak into the result, which keeps the file usable on Rubies older than the one that generated it. The content matches what ruby/ruby has today byte for byte.Generated with Claude Code