Allow SystemCallError.new(errno) - #3185
Merged
Merged
Conversation
MRI treats a single integer argument as an errno. It also accepts a message without an errno and formats the optional func via to_s. Reflect these forms in the signature and allow errno to be nil. Assisted-by: Codex:gpt-6-sol
Replace the legacy StdlibTest case with an instance test. Check both integer and nil results through the type assertion helper. Assisted-by: Codex:gpt-6-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MRI treats a single integer argument for
SystemCallError.newas an errno. It also accepts a message without an errno and formats the optional func via to_s. Reflect these forms in the signature and allow errno to be nil.