Skip to content

Preserve CRLF boundaries when deleting comments #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Preserve CRLF boundaries when deleting comments #3135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/rbs/rewriter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ def replace_comment(comment, content:)
def delete_comment(comment)
location = comment.location or raise "Comment must have a location"
line_start = location.start_pos - location.start_column
line_end = location.end_pos + 1
line_end = location.end_pos
line_end += 1 if buffer.content[line_end] == "\r"
line_end += 1 if buffer.content[line_end] == "\n"
loc = Location.new(buffer, line_start, line_end)
rewrite(loc, "")
end
Expand Down
Loading