Skip to content

Run collection cleaner from CLI #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: master
Choose a base branch
from
+37 −1
Open

Run collection cleaner from CLI #3127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6b1e04
Run collection cleaner from CLI
OskarEichler Aug 29, 2026
d1fdb1b
Test that `rbs collection clean` removes unneeded directories
pocke Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rbs/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,7 +1158,7 @@ def run_collection(args, options)
stderr.puts "#{lock_path} should exist to clean"
return 1
end
Collection::Cleaner.new(lockfile_path: lock_path)
Collection::Cleaner.new(lockfile_path: lock_path).clean
when 'help', 'hel', 'he', 'h'
stdout.puts opts.help
else
Expand Down
36 changes: 36 additions & 0 deletions test/rbs/cli_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1734,6 +1734,42 @@ def test_collection_install__set_pathname__manifest
end
end

def test_collection_clean
Dir.mktmpdir do |dir|
dir = Pathname(dir)

config_path = dir + RBS::Collection::Config::PATH
config_path.write("")

RBS::Collection::Config.to_lockfile_path(config_path).write(<<~YAML)
path: .gem_rbs_collection
gems:
- name: ast
version: "2.4"
source:
type: git
name: ruby/gem_rbs_collection
remote: https://github.com/ruby/gem_rbs_collection.git
revision: b4d3b346d9657543099a35a1fd20347e75b8c523
repo_dir: gems
YAML

collection_dir = dir + ".gem_rbs_collection"
(collection_dir + "ast/2.4").mkpath
(collection_dir + "ast/2.4/ast.rbs").write("class Ast end")
(collection_dir + "ast/2.3").mkpath
(collection_dir + "rainbow/3.0").mkpath

with_cli do |cli|
assert_cli_success cli.run(["--collection", config_path.to_s, "collection", "clean"])
end

assert_predicate(collection_dir + "ast/2.4/ast.rbs", :file?)
refute_predicate(collection_dir + "ast/2.3", :exist?)
refute_predicate(collection_dir + "rainbow/3.0", :exist?)
end
end

def test_subtract
Dir.mktmpdir do |dir|
dir = Pathname(dir)
Expand Down