Repository navigation
Match Ruby escape parsing semantics - #3126
Closed
OskarEichler wants to merge 2 commits into
Closed
OskarEichler wants to merge 2 commits into
OskarEichler wants to merge 2 commits into
Conversation
Collaborator
|
Please add test code for the issue you want to achieve. |
Contributor
Author
|
Added parser-level regression tests for non-octal digits, stopping an octal escape before 8, the three-digit octal limit, a single-digit hex escape at the end of a string, two-digit hex, and an unknown escape without an inserted NUL byte. Rebuilt the native extension; parser suite passes (50 tests, 473 assertions), as do targeted RuboCop and git diff --check. |
Collaborator
|
The problem to be solved is unclear. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: align native unescaping with Ruby octal, hexadecimal, unknown-escape, multibyte replacement, and unsigned character classification behavior.
Verification: focused baseline/fixed reproduction, combined RBS 4.2.0 consumer models, and RuboCop (738 files, zero offenses). Added parser regression tests for octal, hexadecimal, and unknown escapes: 50 tests and 473 assertions pass after rebuilding the native extension. Targeted RuboCop passes.
Compatibility: no public API removal or dependency/version change.