pstore: fixes types, treat it as a collection #2806
Merged
+62
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds hash-like typing to signal its key-value store semantics. it seems like a breaking change, but in practice this has been broken for a while. Other wrong sigs were fixed, such as transaction, which requires a block.
HoneyryderChuck
force-pushed
the
pstore-fixes
branch
from
9d8221a to
4698564
Compare
Contributor
Author
soutaro
reviewed
Jan 26, 2026
Member
|
The rest of the change looks good to me. 🙏 |
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds hash-like typing to signal its key-value store semantics. it seems like a breaking change, but in practice this has been broken for a while.
Other wrong sigs were fixed, such as transaction, which requires a block.