Conversation
…rrent.end continuously
Contributor
|
Very nice. I wonder what the impact will be on the WASM build performance. I'll try to get that stuff more finalized today and into CI. |
ruby/ruby@968b999 Co-Authored-By: Kevin Newton <kddnewton@gmail.com>
ruby/ruby@5026acf Co-Authored-By: Kevin Newton <kddnewton@gmail.com>
ruby/ruby@ec3162c Co-Authored-By: Kevin Newton <kddnewton@gmail.com>
Collaborator
|
ruby/ruby#16418 is already merged. I pushed up the unique commits from that PR and also ruby/ruby#16423, it's back in sync now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch has a ton of optimizations, broadly grouped into:
parser_lex_magic_commentbecause it shows up shockingly high in profiles.With all this in place, I'm seeing about 22% speed gains, using about the same amount of memory.