Remove duplicate lex tests #3856
Open
+0
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RipperTest` already does this (added in ruby#3849) Since it doesn't use the token classes, it also lists out all the excludes instead of just claiming some are passing.
eregon
reviewed
Jan 18, 2026
Comment on lines
-91
to
-94
| result = Prism.lex_compat(source, version: "current") | ||
| assert_equal [], result.errors | ||
|
|
||
| Prism.lex_ripper(source).zip(result.value).each do |(ripper, prism)| |
Member
There was a problem hiding this comment.
Should we still test Prism.lex_compat & Prism.lex_ripper?
They don't seem tested by #3849 from a quick look, but maybe I missed something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RipperTestalready does this (added in #3849)Since it doesn't use the token classes, it also lists out all the excludes instead of just claiming some are passing.
Also see #3855