Add Ripper.tokenize to translation layer
#3854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's public API and trivial to implement.
Collaborator
Author
|
@kddnewton would it be possible to merge my own PRs without review? For some like this where I'm sure it's OK I would like to merge after a day or two if no one approved yet. I guess someone will approve this soon but I'd like to have the option. |
Collaborator
|
Yeah feel free. I'm on vacation this week which is why I've been slow to respond. I will review when I get back after they're merged and if there's an issue I can take care of it after they're fact. |
Collaborator
Author
|
Thing is, I can't. I must pass all the merge requirements and can't self-approve. But you can handle this later after you enjoyed your vacation, I don't want to distract you from your time off. |
Collaborator
|
No problem I just made you an admin so you should be able to now. |
Collaborator
Author
|
Yup, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's public API and trivial to implement.
Ref #3838