Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/net/http.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@

require 'net/protocol'
require 'uri'
require 'resolv'
autoload :OpenSSL, 'openssl'
autoload :Resolv, 'resolv'

module Net #:nodoc:

Expand Down
28 changes: 28 additions & 0 deletions test/net/http/test_require.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# frozen_string_literal: false
require 'net/http'
require 'test/unit'

# Guards the autoload of Resolv in net/http. The checks run in a subprocess
# because this one has resolv loaded already.
class HTTPRequireTest < Test::Unit::TestCase
RESOLV_LOADED = '$LOADED_FEATURES.any? { |f| File.basename(f) == "resolv.rb" }'

def subprocess(script)
lib = File.expand_path('../../../lib', __dir__)
IO.popen([RbConfig.ruby, '-I', lib, '-e', script], &:read)
end

def test_requiring_net_http_does_not_load_resolv
assert_equal 'false', subprocess("require 'net/http'; print #{RESOLV_LOADED}")
end

def test_resolv_is_still_reachable_after_requiring_net_http
script = "require 'net/http'; print Resolv::IPv4::Regex.is_a?(Regexp)"
assert_equal 'true', subprocess(script)
end

def test_referencing_resolv_loads_it
script = "require 'net/http'; Resolv::IPv4::Regex; print #{RESOLV_LOADED}"
assert_equal 'true', subprocess(script)
end
end