Apply response settings to early final Expect responses - #333
Open
OskarEichler wants to merge 1 commit into
Open
Apply response settings to early final Expect responses#333OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply response body encoding, ignore_eof and URI after the response catch, so early final responses to Expect: 100-continue receive the same settings as normal final responses.
Reproduction
Against a bounded local TCP server, send a POST with Expect: 100-continue and continue_timeout=1. Have the server immediately return 417 with a UTF-8 body. Set response_body_encoding=Encoding::UTF_8: before, response.uri is nil and the body is ASCII-8BIT. With ignore_eof=false and a truncated declared body, the early response also incorrectly accepts EOF. All three settings are respected after this change.
Verification
bundle exec rake test: 201 tests, 914 assertions, zero failures/errors, both baseline and this isolated patch.git diff --checkpass. Supplemental Lint scan retains the same 25 pre-existing findings; no new findings by file/cop.Compatibility and limitations
No API or dependency change. Intentional correction: early final responses now honor configured strict EOF handling and body encoding. This does not change informational-response limits or Expect parsing.
Based on master
23e859e92e10e43cad520fcacac3fd43640dba7b. Optional external OpenSSL tests and other Ruby/OS combinations were not run. Existing related issues/PRs were checked; this is a focused correctness change, not a claim of exhaustive coverage.