Skip to content

Detect response byte-order marks independently of string encoding #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −8
Open

Detect response byte-order marks independently of string encoding #327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions lib/net/http/response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,14 +466,13 @@ def sniff_encoding(str, encoding=nil)

# :nodoc:
def check_bom(str)
case str.byteslice(0, 2)
when "\xFE\xFF"
return Encoding::UTF_16BE
when "\xFF\xFE"
return Encoding::UTF_16LE
end
if "\xEF\xBB\xBF" == str.byteslice(0, 3)
return Encoding::UTF_8
case str.getbyte(0)
when 0xFE
return Encoding::UTF_16BE if str.getbyte(1) == 0xFF
when 0xFF
return Encoding::UTF_16LE if str.getbyte(1) == 0xFE
when 0xEF
return Encoding::UTF_8 if str.getbyte(1) == 0xBB && str.getbyte(2) == 0xBF
end
nil
end
Expand Down