Skip to content

Stop running tests that always fail on CI - #1082

Merged
ksss merged 1 commit into
ruby:mainfrom
ksss:fix-test
Oct 10, 2026
Merged

ksss merged 1 commit into
ruby:mainfrom
ksss:fix-test

Conversation

@ksss

@ksss ksss commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator

The test_all_gems CI job keeps failing for three gems (example run). A CI that always fails is not healthy, so this PR stops running these tests by renaming _test to _test_not_run. bin/test already skips a gem when it has no _test directory, so bin/test itself is unchanged.

This PR does not change any RBS files. Directories starting with _ are not installed by rbs collection, so users are not affected.

gem reason
minitest/5.25 minitest 5.25.x requires Ruby < 4.0, so bundle lock fails on Ruby 4.0. This can never pass on CI.
mini_magick/5.0 Steep now reports Ruby::RedundantIgnoreComment for 4 # steep:ignore comments in _test/readme.rb.
sps_king/0.4.0 RBS now reports RBS::InstanceVariableTypeError because attr_accessor in subclasses (CreditTransfer, DirectDebit, DirectDebitTransaction) declares instance variable types that differ from the parent class.

@aki19035vc (mini_magick) @casaper (sps_king)
To re-enable your tests, fix the errors above and rename _test_not_run back to _test in a PR.

🤖 Generated with Claude Code

Rename `_test` to `_test_not_run` so that bin/test skips them.
No RBS files are changed.

- minitest/5.25: minitest 5.25.x requires Ruby < 4.0, so `bundle lock` fails on Ruby 4.0
- mini_magick/5.0: steep reports Ruby::RedundantIgnoreComment
- sps_king/0.4.0: rbs reports RBS::InstanceVariableTypeError

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

@ksss Thanks for your contribution!

Please follow the instructions below for each change.
See also: https://github.com/ruby/gem_rbs_collection/blob/main/docs/CONTRIBUTING.md

Available commands

You can use the following commands by commenting on this PR.

  • /merge: Merge this PR if CI passes

mini_magick

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@aki19035vc, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.


minitest

You changed RBS files for an existing gem.
You can merge this PR yourself because you are a reviewer of this gem.
Just comment /merge to merge this PR.

You can also request a review from other reviewers if you want.


sps_king

You changed RBS files for an existing gem.
You need to get approval from the reviewers of this gem.

@casaper, please review this pull request.
If this change is acceptable, please make a review comment including APPROVE from here.
Screen Shot 2024-03-19 at 14 13 36

After that, the PR author or the reviewers can merge this PR.
Just comment /merge to merge this PR.

@ksss
ksss merged commit 87acc5f into ruby:main Oct 10, 2026
6 checks passed
@ksss
ksss deleted the fix-test branch October 10, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant