Skip to content

misc trace format string fixes - #915

Merged
rtklibexplorer merged 1 commit into
rtklibexplorer:mainfrom
ourairquality:formats-misc
Aug 28, 2026
Merged

misc trace format string fixes#915
rtklibexplorer merged 1 commit into
rtklibexplorer:mainfrom
ourairquality:formats-misc

Conversation

@ourairquality

Copy link
Copy Markdown

No description provided.

@rtklibexplorer

Copy link
Copy Markdown
Owner

From AI review:

  1. src/rcv/unicore.c: sysno is undeclared — won't compile. The local int satsys (which shadows the global satsys() function) was already correct as %d/satsys in the original; looks like a rename was started but only applied to the trace() call, not the declaration or the switch.
  2. app/qtapp/rtkplot_qt/plotmain.cpp, mouseReleaseEvent's #else (pre-Qt6) branch: changed to %f, but event->globalPos() returns QPoint, whose .x()/.y() are int — this introduces a mismatch that wasn't there before. The #if (Qt6) branch above it is correct since globalPosition() returns QPointF.

@ourairquality

Copy link
Copy Markdown
Author

Good points, fixed.

@rtklibexplorer
rtklibexplorer merged commit 352716f into rtklibexplorer:main Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants