Skip to content

chore: use ESM package configuration in all examples#479

Merged
chenjiahan merged 3 commits into
mainfrom
chenjiahan/chore-esm-examples
Jul 19, 2026
Merged

chore: use ESM package configuration in all examples#479
chenjiahan merged 3 commits into
mainfrom
chenjiahan/chore-esm-examples

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Jul 19, 2026

Copy link
Copy Markdown
Member

This PR standardizes every example package on ESM by adding "type": "module" and renaming .mjs / .mts files to .js / .ts.

For Rspack examples, source imports remain extensionless and fullySpecified resolution is disabled with module rules. It also updates CommonJS-only scripts and Node output extensions so the examples continue to build and run under ESM package scopes.

Verification

  • pnpm build:rspack
  • pnpm test
  • pnpm exec rslint
  • Prettier check for all changed files

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cfde6141fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rspack/library-umd/package.json
@chenjiahan
chenjiahan merged commit dc32432 into main Jul 19, 2026
4 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/chore-esm-examples branch July 19, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant