Fix ConsoleLexer ignoring comments=false option#2201
Open
0xdf223 wants to merge 1 commit intorouge-ruby:masterfrom
Open
Fix ConsoleLexer ignoring comments=false option#22010xdf223 wants to merge 1 commit intorouge-ruby:masterfrom
0xdf223 wants to merge 1 commit intorouge-ruby:masterfrom
Conversation
Guard the comment_regex check in process_line with allow_comments? so that setting comments=false actually prevents lines starting with # from being lexed as comments.
Member
|
Good catch, thank you! |
jneen
approved these changes
Feb 4, 2026
Member
Looking at the console lexer again and we may have some regressions too >< |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comment_regexcheck inprocess_linewithallow_comments?so thatcomments=falseactually prevents lines starting with#from being lexed as commentscomments=falsewith a custom prompt treats#-prefixed lines as outputFixes #2200
Test plan
console_spec.rbtests pass##MS_PolicyEventProcessingLogin##is lexed asGeneric.Output(notComment) whencomments=false