[Tut] Solve various problems#22828
Open
dpiparo wants to merge 1 commit into
Open
Conversation
due to shadowing of variables, erroneous logical conditions, and type mismatch
guitargeek
reviewed
Jul 16, 2026
| assert hhc | ||
|
|
||
| hhc.SetToys(ntoys, ntoys / self.mNToysRatio) # can use less ntoys for b hypothesis | ||
| hhc.SetToys(ntoys, int(ntoys / self.mNToysRatio)) # can use less ntoys for b hypothesis |
Contributor
There was a problem hiding this comment.
Suggested change
| hhc.SetToys(ntoys, int(ntoys / self.mNToysRatio)) # can use less ntoys for b hypothesis | |
| hhc.SetToys(ntoys, ntoys // self.mNToysRatio) # can use less ntoys for b hypothesis |
Instead of converting the result to int, I'd prefer integer division directly
guitargeek
reviewed
Jul 16, 2026
| elif type == 0: | ||
| hc.SetToys(ntoys, ntoys / self.mNToysRatio) | ||
| elif Type == 0: | ||
| hc.SetToys(ntoys, int(ntoys / self.mNToysRatio)) |
Contributor
There was a problem hiding this comment.
Suggested change
| hc.SetToys(ntoys, int(ntoys / self.mNToysRatio)) | |
| hc.SetToys(ntoys, ntoys // self.mNToysRatio) |
guitargeek
reviewed
Jul 16, 2026
| elif type == 1: | ||
| hc.SetToys(ntoys, ntoys / self.mNToysRatio) | ||
| elif Type == 1: | ||
| hc.SetToys(ntoys, int(ntoys / self.mNToysRatio)) |
Contributor
There was a problem hiding this comment.
Suggested change
| hc.SetToys(ntoys, int(ntoys / self.mNToysRatio)) | |
| hc.SetToys(ntoys, ntoys // self.mNToysRatio) |
guitargeek
approved these changes
Jul 16, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Just some suggestions for cleaner integer divisions
Member
Author
|
I fully agree. Sorry for not having thought to integer division in the first place ... |
Test Results 23 files 23 suites 3d 19h 54m 36s ⏱️ Results for commit 80dcbb0. |
Member
Author
|
The problem here is that for better or worse, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
due to shadowing of variables, erroneous logical conditions, and type mismatch