[ntuple] Renormalize field type names if needed in SetSchemaFromExisting#22816
Open
silverweed wants to merge 2 commits into
Open
[ntuple] Renormalize field type names if needed in SetSchemaFromExisting#22816silverweed wants to merge 2 commits into
silverweed wants to merge 2 commits into
Conversation
silverweed
force-pushed
the
ntuple_merge_pre636
branch
2 times, most recently
from
July 15, 2026 07:51
bf69035 to
1750f9b
Compare
silverweed
force-pushed
the
ntuple_merge_pre636
branch
from
July 15, 2026 07:54
1750f9b to
e4b5e2e
Compare
Test Results 23 files 23 suites 3d 15h 23m 5s ⏱️ Results for commit 6e804fa. ♻️ This comment has been updated with latest results. |
silverweed
marked this pull request as ready for review
July 16, 2026 11:44
Contributor
Author
|
Update: the user has kindly granted us permission to use his shared files, so I uploaded the integration test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22130.
I have a local integration test for this change but I'm waiting on a user's permission to use their files.
Otherwise we can craft our own files to be merged instead.