Skip to content

[io] Add error message in TFile::Open if LoadPlugin fails #22796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silverweed wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −4
Open

[io] Add error message in TFile::Open if LoadPlugin fails #22796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions io/io/src/TFile.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,8 +1150,10 @@ void TFile::DrawMap(const char *keys, Option_t *option)
{
TPluginHandler *h;
if ((h = gROOT->GetPluginManager()->FindHandler("TFileDrawMap"))) {
if (h->LoadPlugin() == -1)
if (h->LoadPlugin() == -1) {
::Error("TFile::Open", "Failed to load plugin TFileDrawMap");
return;
}
h->ExecPlugin(3, this, keys, option);
}
}
Expand Down Expand Up @@ -3964,17 +3966,21 @@ TFile *TFile::Open(const char *url, Option_t *options, const char *ftitle,

// Network files
if ((h = gROOT->GetPluginManager()->FindHandler("TFile", name))) {
if (h->LoadPlugin() == -1)
if (h->LoadPlugin() == -1) {
::Error("TFile::Open", "Failed to load plugin %s", name.Data());
return nullptr;
}
f = (TFile*) h->ExecPlugin(5, name.Data(), option, ftitle, compress, netopt);
}

} else if (type == kWeb) {

// Web files
if ((h = gROOT->GetPluginManager()->FindHandler("TFile", name))) {
if (h->LoadPlugin() == -1)
if (h->LoadPlugin() == -1) {
::Error("TFile::Open", "Failed to load plugin %s", name.Data());
return nullptr;
}
f = (TFile*) h->ExecPlugin(2, name.Data(), option);
}

Expand All @@ -3992,8 +3998,10 @@ TFile *TFile::Open(const char *url, Option_t *options, const char *ftitle,

// no recognized specification: try the plugin manager
if ((h = gROOT->GetPluginManager()->FindHandler("TFile", name.Data()))) {
if (h->LoadPlugin() == -1)
if (h->LoadPlugin() == -1) {
::Error("TFile::Open", "Failed to load plugin %s", name.Data());
return nullptr;
}
f = (TFile *)h->ExecPlugin(4, name.Data(), option, ftitle, compress);
} else {
// Just try to open it locally but via TFile::Open, so that we pick-up the correct
Expand Down
Loading