Skip to content

Avoid additional python version file to wrong location#21604

Merged
guitargeek merged 1 commit intoroot-project:masterfrom
ellert:pyver-install
Mar 14, 2026
Merged

Avoid additional python version file to wrong location#21604
guitargeek merged 1 commit intoroot-project:masterfrom
ellert:pyver-install

Conversation

@ellert
Copy link
Contributor

@ellert ellert commented Mar 13, 2026

This Pull request:

Changes or fixes:

Install _python_version.py in ROOT sub directory,

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@ellert ellert requested a review from bellenot as a code owner March 13, 2026 20:27
@guitargeek
Copy link
Contributor

Wait I don't understand: when I build and install ROOT master, the _python_version.py already ends up in the ROOT subdirectory, because the ${python_version_file} variable is already set to "${localruntimedir}/ROOT/_python_version.py".

I don't disagree with this PR, but it would be good to understand what is going on here 🙂

@github-actions
Copy link

github-actions bot commented Mar 14, 2026

Test Results

    21 files      21 suites   2d 22h 23m 22s ⏱️
 3 809 tests  3 809 ✅ 0 💤 0 ❌
72 145 runs  72 145 ✅ 0 💤 0 ❌

Results for commit a19eb25.

♻️ This comment has been updated with latest results.

@vepadulano vepadulano requested a review from guitargeek March 14, 2026 09:41
@guitargeek guitargeek changed the title Correct install location for python version file Avoid additional python version file to wrong location Mar 14, 2026
@guitargeek
Copy link
Contributor

Ok I get it now. The file was already correctly implicitly installed by install(DIRECTORY ...) in the ROOT_PYTHON_PACKAGE function. And I think the cleanest fix is just to avoid the additional install command altogether. I have updated the PR accordingly.

Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@guitargeek guitargeek merged commit 3db1965 into root-project:master Mar 14, 2026
29 of 30 checks passed
@ellert ellert deleted the pyver-install branch March 14, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants