[df] Python interface for new Hist action#21584
Merged
hahnjo merged 3 commits intoroot-project:masterfrom Mar 16, 2026
Merged
Conversation
Test Results 22 files 22 suites 3d 4h 57m 40s ⏱️ Results for commit 67202dc. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
Mar 13, 2026
The user may want to customize the bin content type, but still use the JIT for the column types.
This works around limitations for automatic pythonization of variadic function templates with template parameter packs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic pythonization takes care of the overload for one-dimensional
RHistadded in #21370, but for multidimensional histograms new overloads are needed to work around limitations with template parameter packs.FYI @Vipul-Cariappa this works around the discussed problems on the C++ side, to have it working for the next release. If at some point, this starts to work out-of-the-box or with manual pythonizations we can check against the added test case.