[ntuple] Merger: warn when merging RNTuples with higher versions than current#21583
Open
silverweed wants to merge 4 commits intoroot-project:masterfrom
Open
[ntuple] Merger: warn when merging RNTuples with higher versions than current#21583silverweed wants to merge 4 commits intoroot-project:masterfrom
silverweed wants to merge 4 commits intoroot-project:masterfrom
Conversation
ae9e002 to
82d252f
Compare
Test Results 22 files 22 suites 3d 4h 2m 55s ⏱️ For more details on these failures, see this check. Results for commit 4343adf. ♻️ This comment has been updated with latest results. |
82d252f to
0bc0bcd
Compare
0bc0bcd to
4343adf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Makes the RNTupleMerger emit a warning when one of more RNTuples are merged that have a higher version number than the latest.
To do this I added a public
RNTupleDescriptor::GetVersion()and a public staticRNTuple::GetCurrentVersion()method that can be used to compare versions. I made them public because I think they can be useful for users in general, open for discussion.TODO:
Checklist: