Skip to content

[ntuple] Merger: warn when merging RNTuples with higher versions than current#21583

Open
silverweed wants to merge 4 commits intoroot-project:masterfrom
silverweed:ntuple_merge_warn
Open

[ntuple] Merger: warn when merging RNTuples with higher versions than current#21583
silverweed wants to merge 4 commits intoroot-project:masterfrom
silverweed:ntuple_merge_warn

Conversation

@silverweed
Copy link
Contributor

This Pull request:

Makes the RNTupleMerger emit a warning when one of more RNTuples are merged that have a higher version number than the latest.

To do this I added a public RNTupleDescriptor::GetVersion() and a public static RNTuple::GetCurrentVersion() method that can be used to compare versions. I made them public because I think they can be useful for users in general, open for discussion.

TODO:

  • add a way to prevent the merger from trying and merge such RNTuples (this would have to be both a RNTupleMergeOption field and a TFileMerger string option);
  • add a test

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@silverweed silverweed requested review from enirolf and hahnjo March 12, 2026 11:03
@silverweed silverweed self-assigned this Mar 12, 2026
@silverweed silverweed force-pushed the ntuple_merge_warn branch 2 times, most recently from ae9e002 to 82d252f Compare March 12, 2026 13:55
@silverweed silverweed marked this pull request as ready for review March 12, 2026 13:56
@github-actions
Copy link

github-actions bot commented Mar 12, 2026

Test Results

    22 files      22 suites   3d 4h 2m 55s ⏱️
 3 810 tests  3 808 ✅ 1 💤 1 ❌
75 850 runs  75 835 ✅ 9 💤 6 ❌

For more details on these failures, see this check.

Results for commit 4343adf.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@jblomer jblomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants