[NFC][core] group core subdirectories by topic#21568
Open
ferdymercury wants to merge 3 commits intoroot-project:masterfrom
Open
[NFC][core] group core subdirectories by topic#21568ferdymercury wants to merge 3 commits intoroot-project:masterfrom
ferdymercury wants to merge 3 commits intoroot-project:masterfrom
Conversation
ferdymercury
added
clean build
Test Results 20 files 20 suites 2d 19h 0m 41s ⏱️ For more details on these failures, see this check. Results for commit 4c19574. ♻️ This comment has been updated with latest results. |
[cmake] add one more depth level in linkdef search To avoid compilation error with modules=OFF or windows of the type: In file included from .\etc\dictpch\allLinkDefs.h:86: .\etc\dictpch\core\base\inc\LinkDef.h:8:10: fatal error: '../../os/winnt/inc/LinkDef.h' file not found
ferdymercury
requested review from
bellenot,
couet,
dpiparo and
pcanal
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just exploring if such a logic reorganization is doable.
Right now, core is cluttered with many alphabetically sorted subdirs, grouping them by topic/function could help in having better graphical overview.
core/os now groups unix, macos, winnt
core/compression now groups lz4, lzma, zstd, zip
core/parallel now groups imt, multiproc, thread