Skip to content

perf(dsv)!: use hook filters #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sapphi-red wants to merge 2 commits into
base: master
Choose a base branch
from
Open

perf(dsv)!: use hook filters #1986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
766be1b
feat(dsv)!: use hook filters
sapphi-red Mar 23, 2026
749630b
docs(dsv): update Rollup version
sapphi-red Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dsv/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

## Requirements

This plugin requires an [LTS](https://github.com/nodejs/Release) Node version (v14.0.0+) and Rollup v1.20.0+.
This plugin requires an [LTS](https://github.com/nodejs/Release) Node version (v14.0.0+) and Rollup v2.78.0+.

## Install

Expand Down
2 changes: 1 addition & 1 deletion packages/dsv/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"rollup-plugin"
],
"peerDependencies": {
"rollup": "^1.20.0||^2.0.0||^3.0.0||^4.0.0"
"rollup": "^2.78.0||^3.0.0||^4.0.0"
},
"peerDependenciesMeta": {
"rollup": {
Expand Down
34 changes: 22 additions & 12 deletions packages/dsv/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,39 @@ import { createFilter } from '@rollup/pluginutils';
import stripBom from 'strip-bom';

const parsers = { '.csv': csvParse, '.tsv': tsvParse };
const idFilter = new RegExp(
`\\.(?:${Object.keys(parsers)
.map((ext) => ext.slice(1))
.join('|')})$`
);

export default function dsv(options = {}) {
const filter = createFilter(options.include, options.exclude);

return {
name: 'dsv',

transform(code, id) {
if (!filter(id)) return null;
transform: {
filter: {
id: idFilter
},
handler(code, id) {
if (!filter(id)) return null;

const ext = extname(id);
if (!(ext in parsers)) return null;
const ext = extname(id);
if (!(ext in parsers)) return null;

let rows = parsers[ext](stripBom(code));
let rows = parsers[ext](stripBom(code));

if (options.processRow) {
rows = rows.map((row) => options.processRow(row, id) || row);
}
if (options.processRow) {
rows = rows.map((row) => options.processRow(row, id) || row);
}

return {
code: `export default ${toSource(rows)};`,
map: { mappings: '' }
};
return {
code: `export default ${toSource(rows)};`,
map: { mappings: '' }
};
}
}
};
}
Loading