[Feat] [SDK-399] Add java agent for network telemetry events#374
Open
buongarzoni wants to merge 28 commits into
Open
[Feat] [SDK-399] Add java agent for network telemetry events#374buongarzoni wants to merge 28 commits into
buongarzoni wants to merge 28 commits into
Claude / Claude Code Review
completed
Jul 13, 2026 in 32m 37s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | rollbar-java-agent/src/main/java/com/rollbar/agent/NetworkEventBridge.java:141-155 |
composeUrl misidentifies relative URI with '://' in query as absolute, drops host |
Annotations
claude / Claude Code Review
composeUrl misidentifies relative URI with '://' in query as absolute, drops host
The `contains("://")` check at NetworkEventBridge.java:145 also matches when `://` appears inside a query parameter or path, so a relative request URI carrying a nested URL — e.g. `/api/redirect?url=https://other.example.com/foo` from an OAuth redirect endpoint, URL shortener, or proxy-style API — is misidentified as absolute, the base host is dropped, and after `UrlSanitizer` strips the query the recorded telemetry URL becomes just `/api/redirect` with no host. Narrow trigger (HC4/HC5 host-base
Loading