Normalize and validate host locales - #473
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #439.
Root cause
The locale host functions forwarded OS strings without validating the public
Localeinvariant. They also replaced discovery failures with an inventeden-US, makingNotAvailableunreachable.Fix
.encodingand@modifiersuffixes, and replacing underscores with hyphensCandPOSIXas non-language locales and omit themLocale.parseNotAvailablewhen no valid preferred locale remains instead of inventingen-USVerification
cargo test --locked --lib(18 passed)./scripts/test.py --operation validatewith pinned nightly2026-08-13-2fdd90e(207 Roc tests and all example checks passed)./scripts/test.py --operation build --target x64musl --artifact-dir /tmp/basic-cli-439-artifactsLANG=C->NotAvailable,[]LANG=en_US.UTF-8->en-US,[en-US]LANG=malformed!->NotAvailable,[]A strict Clippy run was also attempted; it is currently blocked by pre-existing warnings in generated ABI glue and unrelated TCP/file code.