Fix SQLite binding double free - #472
Merged
lukewilliamboswell merged 1 commit intoAug 14, 2026
Merged
Conversation
lukewilliamboswell
marked this pull request as ready for review
August 14, 2026 02:51
lukewilliamboswell
deleted the
fix/issue-471-sqlite-binding-double-free
branch
August 14, 2026 02:51
This was referenced Aug 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #471.
Root cause
hosted_sqlite_bindreleased both the transferred list reference and every refcounted field inside its binding records. Roc retains ownership of those nested fields across hosted calls, so the generated caller later released the heap-backedStragain. Literals and small strings masked the bug because they do not have ordinary heap refcounts.Fix
hosted_sqlite_bindnightly-2026-08-13-2fdd90e