Add $endOfStream param to HttpWorkerInterface::respond(), remove deprecations#33
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Prepares the v4 release of the HTTP/PSR-7 worker package by finalizing breaking API removals/changes and updating the minimum supported PHP version.
Changes:
- Removed deprecated helper methods from
PSR7Worker. - Updated
HttpWorkerInterface::respond()to include an$endOfStreamparameter (defaulting totrue). - Bumped the minimum PHP requirement to
>=8.2and updated documentation accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/PSR7Worker.php |
Removes deprecated timeInt() / timeFloat() helpers and related psalm suppression. |
src/HttpWorkerInterface.php |
Extends the public response API with the $endOfStream parameter (BC break). |
composer.json |
Raises PHP requirement to >=8.2 (and keeps requirements sorted). |
README.md |
Updates documented PHP version requirement to match composer.json. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
If there are no changes that require PHP 8.2, we can keep PHP 8.1 |
|
I made class |
2a29a2f to
43255d8
Compare
It doesn't seem like this change is worth raising the PHP version for 😄 |
$endOfStream param to HttpWorkerInterface::respond(), remove deprecations
43255d8 to
dfc4aab
Compare
|
OK) I dropped the commits, which related to upgrade php version |
Prepare v4 release:
HttpWoprkerInterface- add$endOfStreamargument.