Skip to content

Add $endOfStream param to HttpWorkerInterface::respond(), remove deprecations#33

Merged
roxblnfk merged 2 commits intoroadrunner-php:4.xfrom
Kenny1911:prepare-release
Feb 18, 2026
Merged

Add $endOfStream param to HttpWorkerInterface::respond(), remove deprecations#33
roxblnfk merged 2 commits intoroadrunner-php:4.xfrom
Kenny1911:prepare-release

Conversation

@Kenny1911
Copy link
Contributor

Q A
Bugfix?
Breaks BC? ✔️
New feature?

Prepare v4 release:

  • Remove deprecated methods.
  • Bump PHP version to >=8.2
  • Fix signature of HttpWoprkerInterface - add $endOfStream argument.

@coderabbitai
Copy link

coderabbitai bot commented Feb 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prepares the v4 release of the HTTP/PSR-7 worker package by finalizing breaking API removals/changes and updating the minimum supported PHP version.

Changes:

  • Removed deprecated helper methods from PSR7Worker.
  • Updated HttpWorkerInterface::respond() to include an $endOfStream parameter (defaulting to true).
  • Bumped the minimum PHP requirement to >=8.2 and updated documentation accordingly.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/PSR7Worker.php Removes deprecated timeInt() / timeFloat() helpers and related psalm suppression.
src/HttpWorkerInterface.php Extends the public response API with the $endOfStream parameter (BC break).
composer.json Raises PHP requirement to >=8.2 (and keeps requirements sorted).
README.md Updates documented PHP version requirement to match composer.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@roxblnfk
Copy link
Member

If there are no changes that require PHP 8.2, we can keep PHP 8.1

@Kenny1911
Copy link
Contributor Author

I made class Spiral\RoadRunner\Http\Request readonly instead all readonly properties.

@roxblnfk
Copy link
Member

I made class Spiral\RoadRunner\Http\Request readonly instead all readonly properties.

It doesn't seem like this change is worth raising the PHP version for 😄

@roxblnfk roxblnfk changed the title Prepare release Add $endOfStream param to HttpWorkerInterface::respond(), remove deprecations Feb 18, 2026
@Kenny1911
Copy link
Contributor Author

Kenny1911 commented Feb 18, 2026

OK) I dropped the commits, which related to upgrade php version

@roxblnfk roxblnfk merged commit 8e24106 into roadrunner-php:4.x Feb 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments