Merged
Conversation
…efinition owner which may be an interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the necessary work is already here to support legacy instance methods, it just needs to be prettied up.
TODO:
execute_nextwithresolve_legacy_instance_method: trueis still faster than.execute.Support legacy implicit default?No, but it can be hard coded.Benchmark results
In the "large benchmark" in this gem (a basic loop over 1000 objects), using
legacy_instance_methodadds an allocation per object and, in that example, it's 10% slower than usinghash_key:They're both 14x faster than legacy execution 😬
Memory:
1001 more objects: one array and 1000 GraphQL object type instances.