Repository navigation
selectolax: Add version 1.0.0 - #2704
Open
riseproject-dev[bot] wants to merge 3 commits into
Open
riseproject-dev[bot] wants to merge 3 commits into
riseproject-dev[bot] wants to merge 3 commits into
Conversation
Signed-off-by: riseproject-dev[bot] <330740410+riseproject-dev[bot]@users.noreply.github.com>
Contributor
|
Nightly version bump omitted the patches/selectolax/<version> directory for 1.0.0, so the build's unconditional `git apply .../*.patch` step failed with "No such file or directory" before any build/test ran. Copied forward the same patch set from 0.4.13 (unchanged since then).
All 4 musllinux legs (cp312/313/314/314t) segfault (SIGSEGV, exit 139) in tests/test_encoding.py::test_http_equiv_content_type_is_honored, a plain charset-detection test with no recursion; the identical manylinux legs all pass. The crash site varies between a direct hit inside the test call (cp314t) and a delayed hit in unrelated pytest teardown on the other three interpreters, which points to heap corruption in the native extension rather than a stack-size/recursion problem. 0.4.11, 0.4.12 and 0.4.13 all published musllinux riscv64 wheels for this package successfully, so this is a 1.0.0-specific regression, not a musl/riscv64 incompatibility in general. 1.0.0 is a large jump from 0.4.13 and most likely carries a lexbor bump; selectolax's own release workflow (make_release.yml) builds musllinux wheels but runs no test suite against them at all, so a musl-only memory bug introduced by such a bump would ship to every musllinux user unnoticed. Upstream carries a long history of fresh memory-corruption bugs introduced by lexbor version bumps (e.g. #211, #217), which is consistent with this. Drop musllinux from the matrix for now, matching the manylinux-only pattern used elsewhere in this repo when a libc is a genuine blocker rather than a missing dependency. Revisit once a newer selectolax release is available.
luhenry
marked this pull request as ready for review
October 11, 2026 00:27
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically generated by the nightly
check_versions.pyrun.selectolax v0.4.13 -> v1.0.0
Every
- version:entry added todocs/packages/selectolax.yamlis built by this PR's ownbuild-selectolax.ymlrun; merging publishes the wheels.