Skip to content

Make 'do-not-merge' warning on Renovate PHP PR more visible #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nymous wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make 'do-not-merge' warning on Renovate PHP PR more visible #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,16 @@
{
"matchPackageNames": ["php"],
"matchDatasources": ["docker"],
// Override helpers:pinGitHubActionDigests from config:best-practices since we explicitely
// Override docker:pinDigests from config:best-practices since we explicitely
// want the latest PHP patch version and not a pinned Docker image
"pinDigests": false,
"prBodyNotes": [
"**Do NOT merge this PR as-is!**",
"# :warning: Do NOT merge this PR as-is! :warning:",
"",
"This PR is only a reminder that a new PHP version is available, however Renovate doesn't allow us to do everything we need to do.",
"You need to _add_ the new PHP version to the `versions` array in `update.sh` instead of replacing the last.",
"You also need to update the `README.md` to list supported versions."
"You need to:",
" * **add** the new PHP version to the `versions` array in `update.sh` instead of replacing the last;",
" * update the `README.md` to list supported versions."
]
}
]
Expand Down
Loading