Remove attempt to require "node:crypto" on Node 18#348
Merged
Conversation
The original code was intended to shim in support for the webcrypto interface in Node 18, which was included indirectly as `webcrypto` in the "node:crypto" module or globally via the `--no-experimental-global-webcrypto` flag. This change has caused many issues with bundlers and static analyzers which do not like the obfuscated call to `require()`. Node 18 will no longer receive security support as of 30 April 2025[1] and as such it feels like we can now drop this workaround in favor of documenting alternative approaches. [1]: https://endoflife.date/nodejs
aron
changed the title
aron
force-pushed
the
remove-node-crypto
branch
2 times, most recently
from
937058e to
162f294
Compare
erbridge
reviewed
Mar 26, 2025
aron
force-pushed
the
remove-node-crypto
branch
from
162f294 to
ffbf4fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #273 & #345
The original code was intended to shim in support for the webcrypto interface in Node 18, which was included indirectly as
webcryptoin the "node:crypto" module or globally via the--no-experimental-global-webcryptoflag.This change has caused many issues with bundlers and static analyzers which do not like the obfuscated call to
require()see the above tickets.Node 18 will no longer receive security support as of 30 April 20251 and as such it feels like we can now drop this workaround in favor of documenting the alternative approaches.
The test suite has also been updated to use
webcryptoon Node 18.