fix: allow explicit CuDNN with CUDA minor versions#3070
Open
sarptandoven wants to merge 2 commits into
Open
Conversation
anish-sahoo
reviewed
Jun 22, 2026
markphelps
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
11.6as selectors for compatible patch-level base images such as11.6.2.cuda: "11.6"andcudnn: "8", then verifies the selected NVIDIA base image.Why
latestCuDNNForCUDAandcudaBaseImageForalready useversion.Matches, socuda: "11.6"can resolve tonvidia/cuda:11.6.2-cudnn8-devel-ubuntu20.04. The validation path used an exact string comparison, which meant the same config failed early whencudnnwas set explicitly.Test plan
git diff --checkgo test ./pkg/config -run 'TestCUDABaseImageTag|TestLatestCuDNNForCUDA|TestValidateAndCompleteCUDA' -count=1go test ./pkg/config -count=1