Skip to content

chore: Remove runtime schema generation#3003

Open
markphelps wants to merge 3 commits intomainfrom
remove-runtime-schema-generation
Open

chore: Remove runtime schema generation#3003
markphelps wants to merge 3 commits intomainfrom
remove-runtime-schema-generation

Conversation

@markphelps
Copy link
Copy Markdown
Contributor

@markphelps markphelps commented May 6, 2026

Summary

  • Remove the Docker/Python runtime OpenAPI schema generation path and make build-time schema generation static-only.
  • Delete legacy schema fallback integration tests and the static-vs-runtime schema comparison harness command.
  • Update schema architecture docs and agent guidance to describe the static-only schema flow.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 6, 2026

LGTM

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 6, 2026

Based on my thorough review of PR #3003, I have examined the key changes:

Summary of changes:

  • Removes Docker/Python runtime OpenAPI schema generation, making build-time schema generation static-only
  • Deletes legacy Python modules for runtime schema generation (_schemas.py, command/, config.py)
  • Preserves essential error classes (ConfigDoesNotExist, PredictorNotSet) by moving them to errors.py
  • Simplifies pkg/image/build.go by removing the runtime schema generation path
  • Deletes legacy schema fallback integration tests and schema comparison test harness
  • Adds new integration test for unresolvable static schema failures
  • Updates architecture documentation to reflect static-only generation

Verification completed:

  • No remaining references to deleted Python modules
  • GenerateOpenAPISchema in pkg/schema/openapi.go is the correct static generator (not deleted)
  • Tests properly verify legacy code references are absent
  • Error types remain importable for backward compatibility
  • Documentation accurately describes the new static-only flow

The PR is focused, complete, and maintains backward compatibility where needed.

LGTM

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented May 7, 2026

After a thorough review of PR #3003, I've verified the following:

Changes Verified:

  • Runtime schema generation code removed cleanly from pkg/image/build.go
  • Legacy Python modules deleted (_schemas.py, command/, config.py)
  • Error classes preserved in errors.py for backward compatibility
  • Architecture docs updated to describe static-only schema generation
  • New integration test added for unresolvable schema failures
  • All deleted integration tests were specifically testing legacy runtime behavior

Test Results:

  • All pkg/image tests pass (11 tests)
  • All pkg/schema tests pass (23+ tests)
  • Legacy reference check confirms no remaining references to deleted code
  • SDK version validation works correctly (rejects <0.17.0, allows >=0.17.0)

Code Quality:

  • No logic errors detected
  • No security issues identified
  • Proper error handling maintained
  • Architecture documentation accurately reflects the new static-only flow

The PR is focused, complete, and maintains backward compatibility where needed. All components build successfully and tests pass.

LGTM

github run

@markphelps markphelps changed the title Remove runtime schema generation chore: Remove runtime schema generation May 7, 2026
@markphelps markphelps marked this pull request as ready for review May 7, 2026 16:27
@markphelps markphelps requested a review from a team as a code owner May 7, 2026 16:27
@markphelps markphelps requested a review from michaeldwan May 7, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant