Skip to content

Fix state detections on updated PR conversation page#232

Closed
SunsetTechuila wants to merge 1 commit intomainfrom
SunsetTechuila-patch-2
Closed

Fix state detections on updated PR conversation page#232
SunsetTechuila wants to merge 1 commit intomainfrom
SunsetTechuila-patch-2

Conversation

@SunsetTechuila
Copy link
Member

@SunsetTechuila SunsetTechuila commented Feb 14, 2026

If we place the .State selector first, it's possible that we select a badge from the events timeline

Test URL: refined-github/sandbox#124

@fregante
Copy link
Member

Selectors are applied at once, they're not cycled and their order does not matter

@SunsetTechuila
Copy link
Member Author

SunsetTechuila commented Feb 14, 2026

Indeed. I forgot to update the packages after switching branches and thought the selector order was the issue. Perhaps I should work on fewer things in parallel so I can concentrate on each one better. There are so many broken features, and I just want them fixed and the console errors gone

@SunsetTechuila SunsetTechuila deleted the SunsetTechuila-patch-2 branch February 14, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants