Fix state detections on updated PR conversation page#232
Closed
SunsetTechuila wants to merge 1 commit intomainfrom
Closed
Fix state detections on updated PR conversation page#232SunsetTechuila wants to merge 1 commit intomainfrom
SunsetTechuila wants to merge 1 commit intomainfrom
Conversation
Member
|
Selectors are applied at once, they're not cycled and their order does not matter |
Member
Author
|
Indeed. I forgot to update the packages after switching branches and thought the selector order was the issue. Perhaps I should work on fewer things in parallel so I can concentrate on each one better. There are so many broken features, and I just want them fixed and the console errors gone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we place the
.Stateselector first, it's possible that we select a badge from the events timelineTest URL: refined-github/sandbox#124