-
-
Notifications
You must be signed in to change notification settings - Fork 30
Replace manual string parsing in add-examples-to-dts.ts with ts-morph #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: fregante <[email protected]>
…ction Co-authored-by: fregante <[email protected]>
Co-authored-by: fregante <[email protected]>
Co-authored-by: fregante <[email protected]>
Copilot
AI
changed the title
[WIP] Replace custom code in add-examples-to-dts.ts with ts-morph
Replace manual string parsing in add-examples-to-dts.ts with ts-morph
Jan 14, 2026
Member
|
@copilot remove |
Co-authored-by: fregante <[email protected]>
Contributor
Author
Member
|
@copilot Revert last commit |
…les" Co-authored-by: fregante <[email protected]>
Contributor
Author
fregante
approved these changes
Jan 14, 2026
Member
fregante
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It one-shotted it, neat!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
add-examples-to-dts.tsscript used ~150 lines of manual string parsing, regex matching, and array splicing to inject JSDoc comments into generated.d.tsfiles. This approach was fragile and difficult to maintain.Changes
Replaced string manipulation with AST-based parsing:
ProjectandSourceFileAPIs to parse TypeScript declarationsgetVariableStatements()andgetTypeAliases()instead of regexgetJsDocs(),getTags(), andaddJsDoc()APIsExtracted duplicated logic:
addExamplesToNode()helper to handle JSDoc manipulation for anyJSDocableNodeUpdated build tooling:
ts-morphfor TypeScript AST manipulationtsxto execute TypeScript files directlypackage.jsonscript fromnodetotsxBefore/After
Before:
After:
Output remains identical: 312 example URLs added to
index.d.ts.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.