ci: pin buf-action to 1.71.0 to match proto codegen#2529
Merged
Conversation
PR #2512 pinned the buf CLI in .github/workflows/buf.yml to 1.65.0, but #2518 had already bumped codegen (BUF_VERSION in taskfiles/proto.yaml) to 1.71.0 and reformatted every proto with the 1.71.0 formatter. CI then validated 1.71.0-formatted protos with buf 1.65.0, which re-expands the nested message literals that 1.71.0 collapses, so buf format --diff failed on master across ~30 protos. Bump all three buf-action version pins to 1.71.0 so the CI format check matches the committed protos and the codegen source of truth. Verified locally against current master protos: - buf 1.65.0 format --diff --exit-code: exit 100 (reproduces the failure) - buf 1.71.0 format --diff --exit-code: clean Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / validate (pull_request).
|
Member
Author
|
@malinskibeniamin this is a follow-up to #2512 which broke the |
malinskibeniamin
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The post-merge
Buf CI→validatejob is failing onmasterafter #2512: theformatcheck reports diffs on ~30 protos (lint, breaking, and build all pass).Root cause
A semantic collision between two independently-green PRs:
BUF_VERSION: 1.71.0intaskfiles/proto.yamland reformatted every proto into 1.71.0's style (short nested message literals collapsed onto one line).buf-actionto1.65.0, based on the (by then stale) assumption that codegen was still on 1.65.0.So
masternow formats protos with 1.71.0 but the CIvalidatejob checks them with 1.65.0, which re-expands the collapsed literals →Format diffon every affected proto. Thebuf.ymlcomments already say "keep in sync with BUF_VERSION in taskfiles/proto.yaml" — that's the invariant #2512 broke.Fix
Bump all three
buf-actionversion pins in.github/workflows/buf.ymlfrom1.65.0→1.71.0, matchingBUF_VERSIONintaskfiles/proto.yaml. No proto reformatting is needed — the committed protos are already 1.71.0-clean. This is the correct direction since #2518 deliberately moved the repo to the 1.71.0 formatter.Verification
Run against the current
masterprotos:buf format --diff --exit-code🤖 Generated with Claude Code