feat(ui): update redpanda-ui to ui-registry v2.1.0#2528
Draft
c-julin wants to merge 1 commit into
Draft
Conversation
Re-sync all 74 registry components to v2.1.0 (Base UI native API), migrate call sites off the removed compat shim (asChild->render, Accordion/ToggleGroup string[] API, removed transition props, onOpenAutoFocus->initialFocus, resizable direction->orientation), bump recharts->3 and react-resizable-panels->4, add cnfast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates Console's vendored
redpanda-uicomponents to ui-registry v2.1.0 (the Base UI–native major release).Important
Stacked on #2525 (React 19). Registry v2.1.0 components are typed for React 19 (Base UI
useRender, mutableRefObject.current, no string refs). On React 18 this produced 6 type errors in vendored components; all 6 disappear on top of #2525 with zero compat patches. Base this PR onben/console-react-19; review/merge after #2525.Changes
lib/base-ui-compatshim.upgrading-to-base-uiguide + codemod):asChild→renderacross ~65 files (jscodeshift codemod) + the expression-child cases the codemod skips.type/collapsible;value/defaultValuenowstring[];onValueChangeis(value[], details).type;valuenowstring[]; callbacks destructure[v].transitionprop from Progress / Collapsible / Popover / Tabs / Card.onOpenAutoFocus={e => e.preventDefault()}→initialFocus={false}.animated/motion props (entrance animations on the rp-connect onboarding cards are dropped — see Follow-ups).recharts2 → 3,react-resizable-panels3 → 4 (direction→orientation), addedcnfast(newcn()impl inutils).Type-check status
tsgois clean except 5 errors at the React-19 + shiki/react-markdown typing boundary (code-block-dynamic.tsx,use-shiki.tsx).use-shiki.tsxis byte-identical to the #2525 base (untouched by this PR) yet errors — i.e. this friction belongs to finalizing React 19, not the registry bump. All five share one root cause (aprecomponent whoseComponentProps<'pre'>doesn't match hast'sComponentstype) and should resolve together as #2525 settles its shiki typings.Follow-ups
pre-component typing (jointly with feat(frontend): migrate to React 19 via Module Federation bridge #2525).animatedpath) by wrapping inmotion.div.data-[state=…]Tailwind selectors in app code still use the Radix attribute names; remap to Base UI (data-open/data-popup-open/data-panel-open/data-pressed) for correct open/active styling (visual-only, not a type error).🤖 Generated with Claude Code