Skip to content

Make Azure management bucket objects private #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frenchfrywpepper wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −23
Open

Make Azure management bucket objects private #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions customer-managed/azure/terraform/.terraform.lock.hcl
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions customer-managed/azure/terraform/network.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ resource "azurerm_subnet" "private" {
virtual_network_name = local.vnet_name
address_prefixes = [each.value.cidr]

private_endpoint_network_policies = "Enabled"

# Use Azure's internal network to reach out to the following Azure services
service_endpoints = [
"Microsoft.Storage.Global",
Expand All @@ -51,6 +53,8 @@ resource "azurerm_subnet" "public" {
virtual_network_name = local.vnet_name
address_prefixes = [each.value.cidr]

private_endpoint_network_policies = "Enabled"

# Use Azure's internal network to reach out to the following Azure services
service_endpoints = [
"Microsoft.Storage.Global",
Expand Down
2 changes: 1 addition & 1 deletion customer-managed/azure/terraform/providers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = "=3.98.0"
version = "=4.47.0"
}
}
}
Expand Down
13 changes: 6 additions & 7 deletions customer-managed/azure/terraform/storage.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ resource "azurerm_storage_account" "management" {
access_tier = "Hot"

public_network_access_enabled = true
allow_nested_items_to_be_public = true
allow_nested_items_to_be_public = false

cross_tenant_replication_enabled = false
shared_access_key_enabled = false
Expand All @@ -38,8 +38,8 @@ resource "azurerm_storage_account" "management" {
resource "azurerm_storage_container" "management" {
###### TODO change var. to local.
name = "${local.resource_name_prefix}${var.redpanda_management_storage_container_name}"
storage_account_name = azurerm_storage_account.management.name
container_access_type = "blob"
storage_account_id = azurerm_storage_account.management.id
container_access_type = "private"
depends_on = [
azurerm_storage_account.management
]
Expand All @@ -62,7 +62,7 @@ resource "azurerm_storage_account" "tiered_storage" {
cross_tenant_replication_enabled = false
shared_access_key_enabled = false
infrastructure_encryption_enabled = true
enable_https_traffic_only = true
https_traffic_only_enabled = true
default_to_oauth_authentication = true

blob_properties {
Expand All @@ -75,7 +75,6 @@ resource "azurerm_storage_account" "tiered_storage" {
}

resource "azurerm_storage_container" "tiered_storage" {
name = "${local.resource_name_prefix}${var.redpanda_tiered_storage_container_name}"
storage_account_name = azurerm_storage_account.tiered_storage.name
container_access_type = "private"
name = "${local.resource_name_prefix}${var.redpanda_tiered_storage_container_name}"
storage_account_id = azurerm_storage_account.tiered_storage.id
}